Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks API iOS Encapsulation (Uplift to 1.27.x) #9204

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Bookmarks API iOS Encapsulation (Uplift to 1.27.x) #9204

merged 1 commit into from
Jun 22, 2021

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jun 21, 2021 •
edited by kjozwiak
Loading

Uplift of #9145
Resolves brave/brave-ios#3802

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel requested a review from a team June 21, 2021 16:11
@soner-yuksel soner-yuksel self-assigned this Jun 21, 2021
@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 21, 2021
@soner-yuksel soner-yuksel added this to the 1.27.x - Beta milestone Jun 21, 2021
kjozwiak
kjozwiak approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.27.x approved after deliberating wit @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 1db4a8e into 1.27.x Jun 22, 2021
@kjozwiak kjozwiak deleted the ios/bookmarks-api-change_1.27.x branch June 22, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson

Assignees

@soner-yuksel soner-yuksel

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @kjozwiak