Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store last wallet unlocked YMD in preferences #9205

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Store last wallet unlocked YMD in preferences #9205

merged 1 commit into from
Jun 22, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 21, 2021

Resolves brave/brave-browser#16174
Related PR: brave/ethereum-remote-client#246

This stores the last wallet unlock year-month-day (YMD) for both the Crypto Wallets extension and the new wallet. It does not differentiate between the two.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
    • This work is just for the local preference that is stored on the user's machine, so no security/privacy review needed for it.
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@kkuehlz kkuehlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 87ba3b7 into master Jun 22, 2021
@bbondy bbondy deleted the stats branch June 22, 2021 17:43
@bbondy bbondy added this to the 1.28.x - Nightly milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose wallet_enabled timestamp to stats
2 participants