Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave News - Fixed publisher card title font-family #9281

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Jun 29, 2021

Fix brave/brave-browser#13610

This resolves span element's font-family deep down in the tree being computed using system defaults in which i added an explicit font-family definition.

Ideally we should add a font-family definition on button element in the defaults text_defaults.css

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook requested a review from petemill June 29, 2021 22:02
@nullhook nullhook changed the title added font family on span element [Desktop] Brave News - Fixed publisher card title font-family Jun 29, 2021
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🍾

@nullhook nullhook merged commit f19b7eb into master Jun 30, 2021
@nullhook nullhook deleted the bug/publisherfont branch June 30, 2021 04:05
@nullhook nullhook added this to the 1.28.x - Nightly milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News - publisher card title has incorrect font
2 participants