Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ads resources are not loaded after browser restart - 1.27.x #9415

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fixes ads resources are not loaded after browser restart - 1.27.x #9415

merged 1 commit into from
Jul 14, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 13, 2021

Uplift of #9410
Resolves brave/brave-browser#16918

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team July 13, 2021 16:30
@tmancey tmancey self-assigned this Jul 13, 2021
@tmancey tmancey changed the title Fixes ads resources are not loaded after browser restart Fixes ads resources are not loaded after browser restart - 1.27.x Jul 13, 2021
LaurenWags
LaurenWags approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.27.x is approved after deliberating with @brave/uplift-approvers 👍🏻

@LaurenWags LaurenWags merged commit c852121 into 1.27.x Jul 14, 2021
@LaurenWags LaurenWags deleted the issues/16918-1.27.x branch July 14, 2021 14:08
@LaurenWags LaurenWags added this to the 1.27.x - Beta milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @LaurenWags