-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes users should not receive ads for a category if the user opted-out or from a creative set if a user disliked #9617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/17305
branch
2 times, most recently
from
August 2, 2021 21:06
f5eca22
to
8105fba
Compare
emerick
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
moritzhaller
reviewed
Aug 3, 2021
moritzhaller
suggested changes
Aug 3, 2021
...rnal/frequency_capping/exclusion_rules/marked_to_no_longer_receive_frequency_cap_unittest.cc
Show resolved
Hide resolved
aseren
reviewed
Aug 3, 2021
.../ads/internal/frequency_capping/exclusion_rules/marked_to_no_longer_receive_frequency_cap.cc
Outdated
Show resolved
Hide resolved
aseren
approved these changes
Aug 3, 2021
moritzhaller
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
tmancey
force-pushed
the
issues/17305
branch
3 times, most recently
from
August 3, 2021 14:56
eadfe31
to
e058436
Compare
tmancey
changed the title
Fixes users should no longer receive ads for a category if the user opted-out
Fixes users should not receive ads for a category if the user opted-out or from a creative set if a user disliked
Aug 3, 2021
…ut or from a creative set if a user disliked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17305
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#17305