Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes users should not receive ads for a category if the user opted-out or from a creative set if a user disliked #9617

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 2, 2021

Resolves brave/brave-browser#17305

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#17305

@tmancey tmancey self-assigned this Aug 2, 2021
@tmancey tmancey force-pushed the issues/17305 branch 2 times, most recently from f5eca22 to 8105fba Compare August 2, 2021 21:06
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moritzhaller moritzhaller self-requested a review August 3, 2021 06:22
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@tmancey tmancey force-pushed the issues/17305 branch 3 times, most recently from eadfe31 to e058436 Compare August 3, 2021 14:56
@tmancey tmancey changed the title Fixes users should no longer receive ads for a category if the user opted-out Fixes users should not receive ads for a category if the user opted-out or from a creative set if a user disliked Aug 3, 2021
…ut or from a creative set if a user disliked
@tmancey tmancey merged commit 42c35f8 into master Aug 3, 2021
@tmancey tmancey deleted the issues/17305 branch August 3, 2021 17:28
@tmancey tmancey added this to the 1.29.x - Nightly milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users should not receive ads for a category if the user opted-out or from a creative set if a user disliked
4 participants