Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to toggle dark mode blocking when fingerprinting=strict #9735

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Aug 12, 2021

Resolves brave/brave-browser#17139.

I'm working on a fix to disable Brave Shields when there's a navigation error which will address general issues of that class (plus remove confusing UX), but in the meantime, adding an opt-out for folks who don't want fingerprinting strict to mess with their dark mode.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@ShivanKaul ShivanKaul requested a review from a team as a code owner August 12, 2021 06:22
@ShivanKaul ShivanKaul changed the title Add feature flag to allow turning off dark mode blocking in fingerprinting strict mode Add feature flag to toggle dark mode blocking when fingerprinting=strict Aug 12, 2021
@@ -37,6 +37,8 @@ const base::Feature kBraveDomainBlock{"BraveDomainBlock",
// potentially blocked by Brave Shields.
const base::Feature kBraveExtensionNetworkBlocking{
"BraveExtensionNetworkBlocking", base::FEATURE_DISABLED_BY_DEFAULT};

// When enabled, Brave will always report Light in Fingerprinting: Strict mode
const base::Feature kBraveDarkModeBlock{"kBraveDarkModeBlock",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove k from the string: "kBraveDarkModeBlock" -> "BraveDarkModeBlock"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ShivanKaul ShivanKaul force-pushed the fingerprinting/dark-mode-block-feature-flag branch from 6669d08 to a6c01e9 Compare August 13, 2021 07:08
@IcyMidnight
Copy link

Thanks for adding this flag! It would be really nice to get it promoted to a configuration option in the main privacy settings view. Any appetite for that?

@ShivanKaul
Copy link
Collaborator Author

We considered that, but we want to avoid cluttering the privacy settings (there's already a lot there). Happy to take a look at / help with a PR though.

@meduzen
Copy link

meduzen commented Jan 16, 2023

For anyone coming here via search engines, the follow-up seems to be on brave/brave-browser#21420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 1.27.108 causes breakage in dark mode
5 participants