-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag to toggle dark mode blocking when fingerprinting=strict #9735
Add feature flag to toggle dark mode blocking when fingerprinting=strict #9735
Conversation
@@ -37,6 +37,8 @@ const base::Feature kBraveDomainBlock{"BraveDomainBlock", | |||
// potentially blocked by Brave Shields. | |||
const base::Feature kBraveExtensionNetworkBlocking{ | |||
"BraveExtensionNetworkBlocking", base::FEATURE_DISABLED_BY_DEFAULT}; | |||
|
|||
// When enabled, Brave will always report Light in Fingerprinting: Strict mode | |||
const base::Feature kBraveDarkModeBlock{"kBraveDarkModeBlock", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove k
from the string: "kBraveDarkModeBlock"
-> "BraveDarkModeBlock"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
6669d08
to
a6c01e9
Compare
Thanks for adding this flag! It would be really nice to get it promoted to a configuration option in the main privacy settings view. Any appetite for that? |
We considered that, but we want to avoid cluttering the privacy settings (there's already a lot there). Happy to take a look at / help with a PR though. |
For anyone coming here via search engines, the follow-up seems to be on brave/brave-browser#21420. |
Resolves brave/brave-browser#17139.
I'm working on a fix to disable Brave Shields when there's a navigation error which will address general issues of that class (plus remove confusing UX), but in the meantime, adding an opt-out for folks who don't want fingerprinting strict to mess with their dark mode.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: