-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes follow up to #17723: Notification ads are not shown on Linux #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/17813
branch
2 times, most recently
from
September 1, 2021 20:36
a441762
to
8dcc411
Compare
emerick
approved these changes
Sep 1, 2021
tmancey
force-pushed
the
issues/17813
branch
4 times, most recently
from
September 1, 2021 22:02
a3a11ab
to
1acbc89
Compare
aseren
approved these changes
Sep 2, 2021
tmancey
added
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
labels
Sep 2, 2021
CI passed for all platforms except Windows. Fixing Windows specific code and restarting CI. |
tmancey
force-pushed
the
issues/17813
branch
3 times, most recently
from
September 2, 2021 15:20
63bbe39
to
f45bd0e
Compare
tmancey
force-pushed
the
issues/17813
branch
2 times, most recently
from
September 2, 2021 15:46
dc97549
to
7dc3a89
Compare
moritzhaller
approved these changes
Sep 2, 2021
tmancey
force-pushed
the
issues/17813
branch
from
September 2, 2021 15:57
7dc3a89
to
4665fc6
Compare
tmancey
force-pushed
the
issues/17813
branch
from
September 2, 2021 16:34
4665fc6
to
1f2d012
Compare
LGTM Verification passed on
Verified system notifications are shown by default Verified custom ads notifications are shown when overridden through variations. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-ios
Do not run CI builds for iOS
CI/skip-macos-x64
Do not run CI builds for macOS x64
feature/ads
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17813
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#17813. Needs testing on all platforms.