Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes follow up to #17723: Notification ads are not shown on Linux #9947

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 1, 2021

Resolves brave/brave-browser#17813

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#17813. Needs testing on all platforms.

@tmancey tmancey self-assigned this Sep 1, 2021
@tmancey tmancey requested a review from aseren September 1, 2021 20:30
@tmancey tmancey force-pushed the issues/17813 branch 2 times, most recently from a441762 to 8dcc411 Compare September 1, 2021 20:36
@tmancey tmancey force-pushed the issues/17813 branch 4 times, most recently from a3a11ab to 1acbc89 Compare September 1, 2021 22:02
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Sep 2, 2021
@tmancey
Copy link
Collaborator Author

tmancey commented Sep 2, 2021

CI passed for all platforms except Windows. Fixing Windows specific code and restarting CI.

@tmancey tmancey force-pushed the issues/17813 branch 3 times, most recently from 63bbe39 to f45bd0e Compare September 2, 2021 15:20
@tmancey tmancey removed the CI/skip-android Do not run CI builds for Android label Sep 2, 2021
@tmancey tmancey force-pushed the issues/17813 branch 2 times, most recently from dc97549 to 7dc3a89 Compare September 2, 2021 15:46
@tmancey tmancey merged commit 79f6185 into master Sep 2, 2021
@tmancey tmancey deleted the issues/17813 branch September 2, 2021 18:35
@tmancey tmancey added this to the 1.31.x - Nightly milestone Sep 2, 2021
@btlechowski
Copy link

btlechowski commented Sep 7, 2021

LGTM

Verification passed on

Brave 1.31.23 Chromium: 93.0.4577.63 (Official Build) nightly (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified system notifications are shown by default
image

Verified custom ads notifications are shown when overridden through variations.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to #17723: Notification ads are not shown on Linux
5 participants