Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include eth.link in public suffix only when include_private is true #9951

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Sep 1, 2021

Resolves brave/brave-browser#17815

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Open https://swapr.eth.link/, should not show invalid cert error.

@yrliou yrliou requested a review from a team as a code owner September 1, 2021 22:47
@yrliou yrliou self-assigned this Sep 1, 2021
@yrliou yrliou changed the title Include eth.link in public suffic only when include_private is true Include eth.link in public suffix only when include_private is true Sep 1, 2021
@yrliou yrliou added this to the 1.31.x - Nightly milestone Sep 1, 2021
@yrliou yrliou force-pushed the eth_link_include_private branch 2 times, most recently from 9bc60b8 to 240f9ea Compare September 1, 2021 23:10
@yrliou
Copy link
Member Author

yrliou commented Sep 2, 2021

Unrelated CI failure:
Android: unrelated s3 upload failure
Windows: unrelated browser test failure, AdBlockServiceTest.SubscribeToCustomSubscription
Merging.

@stephendonner
Copy link
Contributor

stephendonner commented Sep 3, 2021

Verified PASSED using

Brave 1.31.18 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 12.0 (Build 21A5506j)

Steps:

  1. new profile
  2. launched Brave
  3. opened Developer Tools
  4. chose the Network panel
  5. loaded https://swapr.eth.link/

Confirmed I got a 200 OK from https://swapr.eth.link/

Screen Shot 2021-09-02 at 5 19 25 PM

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.31.23 Chromium: 93.0.4577.63 (Official Build) nightly (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19042.1165)

When running through the above, I ran into an issue where the website 404 when attempting to load the locales json file. However, this is an issue on their end and not Brave related. Just a heads up for @brave/legacy_qa when we run through the above on 1.29.x. Example of the issue:

Example (Canada) Example (Canada)
1 2
Example (USA) Example (USA)
us1 us2

However, the page loads without any issues after a few refreshes and doesn't run into the certificate error that's mentioned via brave/brave-browser#17815 (comment). Example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cert invalid error when visiting *.eth.link
3 participants