This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Show browser action as disabled when shield is disabled #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
changed the title
cezaraugusto
force-pushed
the
shields/disabled-browser-action
branch
from
2f3f8f0 to
e8efa1e
Compare
cezaraugusto
force-pushed
the
shields/disabled-browser-action
branch
from
e8efa1e to
e10e5b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#240
address brave/brave-browser#169 (partially)
Test Plan
Manual Test Plan
/^http/should show a disabled browserAction icon (partial of Shields should be disabled for about pages brave-browser#169)