This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Use braveShields's contentSetting method for shield configuration #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2018
Use braveShields's contentSetting method instead of chrome.contentSetting. This will enable user able to edit shields setting. So far, user can't edit shields setting because chrome doesn't allow editing configuration set by extension. Our new methods stores configuration to user preference store instead of extension store.
simonhong
changed the title
bbondy
approved these changes
Sep 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use braveShields's contentSetting method instead of chrome.contentSetting.
This will enable user able to edit shields setting.
So far, user can't edit shields setting because chrome doesn't allow editing configuration set by extension.
Our new methods stores configuration to user preference store instead of extension store.
This PR should be merged after reviewing brave/brave-core#439.
Issue brave/brave-browser#232