Fix #4040: Add a new section in history for items dated earlier than …

…last month period in limits (#4041)
brave · Sep 3, 2021 · 38a1445 · 38a1445
1 parent 7be04ea
commit 38a1445
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/BraveShared/BraveStrings.swift b/BraveShared/BraveStrings.swift
@@ -617,6 +617,7 @@ extension Strings {
     public static let yesterday = NSLocalizedString("Yesterday", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Yesterday", comment: "History tableview section header")
     public static let lastWeek = NSLocalizedString("LastWeek", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Last week", comment: "History tableview section header")
     public static let lastMonth = NSLocalizedString("LastMonth", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Last month", comment: "History tableview section header")
+    public static let earlier = NSLocalizedString("Earlier", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Earlier", comment: "History tableview section header that indicated history items earlier than last month")
     public static let savedLogins = NSLocalizedString("SavedLogins", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Saved Logins", comment: "Settings item for clearing passwords and login data")
     public static let downloadedFiles = NSLocalizedString("DownloadedFiles", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Downloaded files", comment: "Settings item for clearing downloaded files.")
     public static let browsingHistory = NSLocalizedString("BrowsingHistory", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Browsing History", comment: "Settings item for clearing browsing history")

diff --git a/Client/Frontend/Sync/BraveCore/History/HistoryFetchers.swift b/Client/Frontend/Sync/BraveCore/History/HistoryFetchers.swift
@@ -134,7 +134,8 @@ class Historyv2Fetcher: NSObject, HistoryV2FetchResultsController {
     private var sectionDetails: OrderedDictionary<Historyv2.Section, Int> = [.today: 0,
                                                                              .yesterday: 0,
                                                                              .lastWeek: 0,
-                                                                             .thisMonth: 0]
+                                                                             .thisMonth: 0,
+                                                                             .earlier: 0]
 
     private func clearHistoryData() {
         historyList.removeAll()

diff --git a/Client/Frontend/Sync/BraveCore/History/Historyv2.swift b/Client/Frontend/Sync/BraveCore/History/Historyv2.swift
@@ -26,6 +26,8 @@ class Historyv2: WebsitePresentable {
         case lastWeek
         /// History happened between end of this week and end of this month
         case thisMonth
+        /// History happened after the end of this month
+        case earlier
 
         /// The list of titles time period
         var title: String {
@@ -38,6 +40,8 @@ class Historyv2: WebsitePresentable {
                      return Strings.lastWeek
                 case .thisMonth:
                      return Strings.lastMonth
+                case .earlier:
+                     return Strings.earlier
             }
         }
     }
@@ -98,7 +102,7 @@ class Historyv2: WebsitePresentable {
             return .thisMonth
         }
 
-        return nil
+        return .earlier
     }
 
     private func getDate(_ dayOffset: Int) -> Date {