Fix #8167: Show Brave News onboarding if language support is added la…

…ter (#8170)

This is only supported for new users since a new preference is required to track language check failures

App/iOS/Delegates/AppDelegate.swift

@@ -92,11 +92,20 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
  Preferences.BraveNews.isShowingOptIn.value = true
  }
 
- if !Preferences.BraveNews.languageChecked.value,
- let languageCode = Locale.preferredLanguages.first?.prefix(2) {
+ // If the user's language was checked but not included in the News supported languages list check it again
+ // each launch since updates could add support for a new language. If a user previously opted in to News
+ // however then we shouldn't show the opt-in card again.
+ let shouldPerformLanguageCheck = !Preferences.BraveNews.languageChecked.value || 
+ Preferences.BraveNews.languageWasUnavailableDuringCheck.value == true
+ let isNewsEnabledOrPreviouslyOptedIn = Preferences.BraveNews.isEnabled.value || 
+ Preferences.BraveNews.userOptedIn.value
+ if shouldPerformLanguageCheck, !isNewsEnabledOrPreviouslyOptedIn,
+ let languageCode = Locale.preferredLanguages.first?.prefix(2) {
  Preferences.BraveNews.languageChecked.value = true
- // Base opt-in visibility on whether or not the user's language is supported in BT
- Preferences.BraveNews.isShowingOptIn.value = FeedDataSource.supportedLanguages.contains(String(languageCode)) || FeedDataSource.knownSupportedLocales.contains(Locale.current.identifier)
+ let languageShouldShowOptIn = FeedDataSource.supportedLanguages.contains(String(languageCode)) ||
+ FeedDataSource.knownSupportedLocales.contains(Locale.current.identifier)
+ Preferences.BraveNews.languageWasUnavailableDuringCheck.value = !languageShouldShowOptIn
+ Preferences.BraveNews.isShowingOptIn.value = languageShouldShowOptIn
  }
 
  SystemUtils.onFirstRun()

Sources/BraveNews/NewsPreferences.swift

@@ -12,6 +12,7 @@ extension Preferences {
  public static let userOptedIn = Option<Bool>(key: "brave-today.user-opted-in", default: false)
  public static let isEnabled = Option<Bool>(key: "brave-today.enabled", default: true)
  public static let languageChecked = Option<Bool>(key: "brave-today.language-checked", default: false)
+ public static let languageWasUnavailableDuringCheck = Option<Bool?>(key: "brave-today.language-unavailable-when-checked", default: nil)
  public static let debugEnvironment = Option<String?>(key: "brave-today.debug.environment", default: nil)
  /// A list of channels followed for a locale.
  ///