Fix #8255: Reordering Favourites shows duplicated items (#8314)

brave · Oct 26, 2023 · a2836da · a2836da
1 parent 5a82064
commit a2836da
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/Sources/Brave/Frontend/Browser/New Tab Page/NewTabPageViewController.swift b/Sources/Brave/Frontend/Browser/New Tab Page/NewTabPageViewController.swift
@@ -1232,13 +1232,21 @@ extension NewTabPageViewController: UICollectionViewDragDelegate, UICollectionVi
 
  if coordinator.proposal.operation == .move {
  guard let item = coordinator.items.first else { return }
+ _ = coordinator.drop(item.dragItem, toItemAt: destinationIndexPath)
 
+ guard let favouritesSection = sections.firstIndex(where: { $0 is FavoritesSectionProvider }) else {
+ return
+ }
+
  Favorite.reorder(
  sourceIndexPath: sourceIndexPath,
  destinationIndexPath: destinationIndexPath,
  isInteractiveDragReorder: true
  )
- _ = coordinator.drop(item.dragItem, toItemAt: destinationIndexPath)
+
+ UIView.performWithoutAnimation {
+ self.collectionView.reloadSections(IndexSet(integer: favouritesSection))
+ }
 
  }
  }