Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Fix #8041: Remove bookmark count
Browse files Browse the repository at this point in the history
  • Loading branch information
iccub committed Sep 8, 2023
1 parent becf901 commit a92b037
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -455,14 +455,6 @@ class BookmarksViewController: SiteTableViewController, ToolbarUrlActionsProtoco
cell.textLabel?.font = UIFont.boldSystemFont(ofSize: fontSize)
cell.accessoryType = .disclosureIndicator
cell.setRightBadge(nil)

// 0 bookmarks
// 1 bookmark
// 2 bookmarks
// ...
let bookmarksCount = item.children?.filter({ !$0.isFolder }).count ?? 0
cell.detailTextLabel?.text = String(format: bookmarksCount == 1 ? Strings.bookmarkSingleCount : Strings.bookmarkMultipleCount, bookmarksCount)
cell.detailTextLabel?.font = UIFont.systemFont(ofSize: fontSize)
}
}

Expand Down
2 changes: 0 additions & 2 deletions Sources/BraveStrings/BraveStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1174,8 +1174,6 @@ extension Strings {
public static let favoritesRootLevelCellTitle = NSLocalizedString("FavoritesRootLevelCellTitle", tableName: "BraveShared", bundle: .module, value: "Favorites", comment: "Title for favorites cell")
public static let addFolderActionCellTitle = NSLocalizedString("AddFolderActionCellTitle", tableName: "BraveShared", bundle: .module, value: "New folder", comment: "Cell title for add folder action")
public static let editBookmarkTableLocationHeader = NSLocalizedString("EditBookmarkTableLocationHeader", tableName: "BraveShared", bundle: .module, value: "Location", comment: "Header title for bookmark save location")
public static let bookmarkSingleCount = NSLocalizedString("BookmarkSingleCount", tableName: "BraveShared", bundle: .module, value: "%d bookmark", comment: "Title for a single bookmark (Do not localize %d, it is a placeholder for a number. IE: 1 bookmark)")
public static let bookmarkMultipleCount = NSLocalizedString("BookmarkMultipleCount", tableName: "BraveShared", bundle: .module, value: "%d bookmarks", comment: "Title for a single bookmark (Do not localize %d, it is a placeholder for a number. IE: 10 bookmarks")
public static let newBookmarkTitle = NSLocalizedString("NewBookmarkTitle", tableName: "BraveShared", bundle: .module, value: "New bookmark", comment: "Title for adding new bookmark")
public static let newFolderTitle = NSLocalizedString("NewFolderTitle", tableName: "BraveShared", bundle: .module, value: "New folder", comment: "Title for adding new folder")
public static let editBookmarkTitle = NSLocalizedString("EditBookmarkTitle", tableName: "BraveShared", bundle: .module, value: "Edit bookmark", comment: "Title for editing a bookmark")
Expand Down

0 comments on commit a92b037

Please sign in to comment.