Detail local text is added for suggestion switch and descriptions

brave · Dec 8, 2023 · daf98c6 · daf98c6
1 parent bdbb719
commit daf98c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/...ces/Brave/Frontend/Settings/General/SearchEngines/SearchSettingsTableViewController.swift b/...ces/Brave/Frontend/Settings/General/SearchEngines/SearchSettingsTableViewController.swift
@@ -242,8 +242,11 @@ class SearchSettingsTableViewController: UITableViewController {
  $0.isOn = searchEngines.shouldShowBrowserSuggestions
  }
 
- cell = tableView.dequeueReusableCell(withIdentifier: Constants.showBrowserSuggestionsRowIdentifier, for: indexPath).then {
+ cell = UITableViewCell(style: .subtitle, reuseIdentifier: Constants.showBrowserSuggestionsRowIdentifier).then {
  $0.textLabel?.text = Strings.searchSettingBrowserSuggestionCellTitle
+ $0.detailTextLabel?.numberOfLines = 0
+ $0.detailTextLabel?.textColor = .secondaryBraveLabel
+ $0.detailTextLabel?.text = Strings.searchSettingBrowserSuggestionCellDescription
  $0.accessoryView = toggle
  $0.selectionStyle = .none
  }

diff --git a/Sources/BraveStrings/BraveStrings.swift b/Sources/BraveStrings/BraveStrings.swift
@@ -552,6 +552,10 @@ extension Strings {
  NSLocalizedString("SearchSettingBrowserSuggestionCellTitle", tableName: "BraveShared", bundle: .module,
  value: "Show Browser Suggestions",
  comment: "Label for showing browser suggestion setting")
+ public static let searchSettingBrowserSuggestionCellDescription =
+ NSLocalizedString("SearchSettingBrowserSuggestionCellDescription", tableName: "BraveShared", bundle: .module,
+ value: "Turn this on to include results from your History and Bookmarks when searching",
+ comment: "Label for showing browser suggestion setting description")
  public static let searchSettingAddCustomEngineCellTitle =
  NSLocalizedString("searchSettingAddCustomEngineCellTitle", tableName: "BraveShared", bundle: .module,
  value: "Add Custom Search Engine",