Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Favicon on Brave website blends into an orange background on iOS #1092

Closed
karenkliu opened this issue May 17, 2019 · 1 comment
Closed

Favicon on Brave website blends into an orange background on iOS #1092

karenkliu opened this issue May 17, 2019 · 1 comment
Assignees
@kylehickinson
Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14

Comments

@karenkliu
Copy link

Description

Currently the favicon on the Brave website blends into an orange background:
IMG_3559
IMG_ED76A71238F7-1

Expected Result

The favicon should not have an orange background and be the same as it appears on desktop:
Screen Shot 2019-05-16 at 6 10 32 PM
kylehickinson added a commit that referenced this issue Nov 20, 2019
@kylehickinson
Fix #1092: Don't assign a color background to brave.com favicon
66cddf2
@kylehickinson kylehickinson mentioned this issue Nov 20, 2019
Merged
7 tasks
@iccub iccub added this to the 1.14 milestone Nov 21, 2019
@iccub iccub closed this as completed in 35af279 Nov 21, 2019
This was referenced Nov 21, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.22.15)

  • Verified on light theme
    image
  • Verified on dark theme
    image

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.22.15)

  • Verified on light theme
    image
  • Verified on dark theme
    image

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.22.15)

  • Verified on light theme
    image
  • Verified on dark theme
    image

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.22.15)

  • Verified on light theme
    image
  • Verified on dark theme
    image

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.22.15)

  • Verified on light theme
    image
  • Verified on dark theme
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
4 participants
@kylehickinson @karenkliu @iccub @srirambv