Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Setting text updates #1431

Closed
5 tasks done
anthonypkeane opened this issue Aug 26, 2019 · 4 comments
Closed
5 tasks done

Setting text updates #1431

anthonypkeane opened this issue Aug 26, 2019 · 4 comments
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude test-plan/specified
Milestone
1.12

Comments

@anthonypkeane
Copy link

anthonypkeane commented Aug 26, 2019 •
edited by jhreis
Loading

Description:

Please title cap the following in settings

  • Block all Cookies (currently small c)
  • Report a Bug (currently small b)

In Show Tabs Bar:

  • Never Show (currently small s)
  • Always Show (currently small s)
  • Show in Landscape Only (currently small l and o)

Internal Chat: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1566622684384900?thread_ts=1566622584.382100&cid=C06UXF3KJ
@anthonypkeane anthonypkeane mentioned this issue Aug 29, 2019
Closed
jhreis added a commit that referenced this issue Aug 30, 2019
@jhreis
Fix #1431: Capitalized a handful of setting options.
ff99339
@jhreis jhreis added the QA/Yes label Aug 30, 2019
@jhreis jhreis added this to the 1.12 milestone Aug 30, 2019
@jhreis jhreis mentioned this issue Aug 30, 2019
Merged
7 tasks
@iccub iccub closed this as completed in d6c74dd Aug 30, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2019 •
edited by kjozwiak
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.06.21)
image
image

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.10.13):

IMG_0023
IMG_0022

Verification PASSED on iPhone 6s+ using iOS 12.4.1 running 1.12 (19.09.13.06):

IMG_9915
IMG_9914

@kjozwiak
Copy link
Member

@iccub the following settings menu isn't available under iPad:

  • Never Show
  • Always Show
  • Show in Landscape Only

Is the above expected?

@anthonypkeane
Copy link
Author

We don't have it in 1.11.4 @kjozwiak on iPad

@kjozwiak
Copy link
Member

@anthonypkeane correct, the submenu isn't available for iPad under 1.11.4 (19.8.29.21) either. Just wanted to double check to make sure this is expected 👍

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude test-plan/specified
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
5 participants
@kjozwiak @jhreis @iccub @anthonypkeane @srirambv