Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove empty brackets for download popup #1433

Closed
srirambv opened this issue Aug 27, 2019 · 1 comment
Closed

Remove empty brackets for download popup #1433

srirambv opened this issue Aug 27, 2019 · 1 comment
Assignees
@iccub
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.12

Comments

@srirambv
Copy link
Contributor

Description:

If the size of the file isn't determined, empty () is shown next to download. We should probably remove that if its not able to determine the download size

Steps to Reproduce

Actual result:
image

Expected result:
Just have Download instead of Download ()

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12

Device details:
All device with iOS 13

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added blocked: needs design Needs design before work can commence QA/Yes labels Aug 27, 2019
@srirambv srirambv added this to the 1.12 milestone Aug 27, 2019
@iccub iccub removed the blocked: needs design Needs design before work can commence label Aug 27, 2019
@iccub iccub removed this from the 1.12 milestone Aug 27, 2019
@iccub iccub self-assigned this Aug 27, 2019
iccub added a commit that referenced this issue Aug 27, 2019
@iccub
Fix #1433: Don't show brackets for file downloads with unknown size.
8f1f707
@iccub iccub mentioned this issue Aug 27, 2019
Merged
7 tasks
@jhreis jhreis added this to the 1.12 milestone Aug 27, 2019
@jhreis jhreis closed this as completed in 86b1e2a Aug 27, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Sep 7, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.1 running 1.12(19.09.06.21)

  • Verified when download size is small enough its not shown
    image

Verification PASSED on both iPad Air 3rd Generation iOS 13.1 & iPad 4 Mini iOS 12.4.1 running 1.12 (19.09.10.13):

IMG_0027

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

  • Verified when download size is small enough its not shown
    image

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
4 participants
@kjozwiak @jhreis @iccub @srirambv