Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Make DuckDuckGo the default search engine in the following countries #1451

Closed
anthonypkeane opened this issue Aug 28, 2019 · 4 comments
Closed

Make DuckDuckGo the default search engine in the following countries #1451

anthonypkeane opened this issue Aug 28, 2019 · 4 comments
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.12

Comments

@anthonypkeane
Copy link

anthonypkeane commented Aug 28, 2019 •
edited by jhreis
Loading

Description

Please make DuckDuckGo the default search engine in the following countries:

  • Germany
  • Australia
  • New Zealand
  • Ireland

This is for NEW users only

Onboarding will need to be updated

QA Steps

  1. Switch device to one of the above locales
  2. Install Brave
  3. Verify preselected on-boarding option is DDG
@anthonypkeane anthonypkeane added this to the 1.13 milestone Aug 28, 2019
@iccub iccub modified the milestones: 1.13, 1.12 Sep 2, 2019
@iccub iccub self-assigned this Sep 2, 2019
iccub added a commit that referenced this issue Sep 2, 2019
@iccub
Fix #1451: Set DuckDuckGo search engine for certain countries.
59d36d5 
DDG will be set as default for:
- Australia
- Germany
- Ireland
- New Zealand
@iccub iccub mentioned this issue Sep 2, 2019
Merged
7 tasks
@iccub iccub closed this as completed in 0f189c5 Sep 3, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 10, 2019 •
edited
Loading

This is failing on all 4 locales. @jhreis @iccub is this still dependant on https://github.com/brave/internal/issues/648? If so we need to reopen the issue as #1473 doesn't seem to have fixed this
Seems to be working now.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 10, 2019 •
edited
Loading

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.07.03):

  • ensured that DDG is selected via the onboarding experience when installing Brave under Germany, Australia, New Zealand and Ireland
    • ensured that DDG is being used under Standard Tab and Private Tab when skipping onboarding
    • ensured that DDG is being under Standard Tab and Private Tab when completing onboarding

Also ensured that updating 1.11.4 (19.08.29.21 to 1.12 (19.09.07.03) doesn't launch the onboarding experience and leaves the search engines to whatever was selected previously.

IMG_0007

@kjozwiak
Copy link
Member

kjozwiak commented Sep 10, 2019 •
edited
Loading

This is failing on all 4 locales. @jhreis @iccub is this still dependant on brave/internal#648? If so we need to reopen the issue as #1473 doesn't seem to have fixed this

@srirambv seems to be working for my on the iPad. I basically change the Region via Settings to one of the regions mentioned under #1451 (comment) and DDG is the search engine that's selected when the onboarding experience launches on new installs.

@srirambv
Copy link
Contributor

srirambv commented Sep 10, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.07.08)

  • Verified DDG was on top of the list of SE during onboarding and selected by default
  • Verified skipping the onboarding process retained DDG as default SE for both normal/private tabs
  • Verified finishing the onboarding process retained DDG as default SE for both normal/private tabs
  • Verified opening an NPT doesn't prompt DDG modal if no change is made during onboarding
  • Logged DDG modal is not prompted when a different SE is set during onboarding  #1515 for not showing DDG modal when a different SE is set during onboarding other than DDG

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

  • Verified DDG was on top of the list of SE during onboarding and selected by default
  • Verified skipping the onboarding process retained DDG as default SE for both normal/private tabs
  • Verified finishing the onboarding process retained DDG as default SE for both normal/private tabs
  • Verified opening an NPT doesn't prompt DDG modal if no change is made during onboarding

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
4 participants
@kjozwiak @iccub @anthonypkeane @srirambv