Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix copy for ad grants notification #1942

Closed
kylehickinson opened this issue Nov 12, 2019 · 1 comment
Closed

Fix copy for ad grants notification #1942

kylehickinson opened this issue Nov 12, 2019 · 1 comment
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14

Comments

@kylehickinson
Copy link
Collaborator

Should be Brave Ads | Your rewards from Ads are here!

Icon should be icn-ads (ads megaphone icon)
@kylehickinson kylehickinson added this to the 1.14 milestone Nov 12, 2019
@kylehickinson kylehickinson self-assigned this Nov 12, 2019
kylehickinson added a commit that referenced this issue Nov 12, 2019
@kylehickinson
Fix #1942: Show correct copy & icon for ads grant notifications
48a9f37
@kylehickinson kylehickinson mentioned this issue Nov 12, 2019
Merged
7 tasks
This was referenced Nov 21, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

  • Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)
    image

  • Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.20.19)
    image

  • Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.20.19)
    image

  • Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.20.19)
    image

  • Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.20.19)
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
2 participants
@kylehickinson @srirambv