Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Provide an option to restore lost bookmarks during 1.12 migration #2015

Closed
iccub opened this issue Nov 22, 2019 · 2 comments
Closed

Provide an option to restore lost bookmarks during 1.12 migration #2015

iccub opened this issue Nov 22, 2019 · 2 comments
Assignees
@iccub
Labels
enhancement Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.14.2

Comments

@iccub
Copy link
Contributor

iccub commented Nov 22, 2019

We should provide an option for users to restore their lost bookmarks.
Basic implementation:

  1. Add new Recovered Bookmarks folder in new DB
  2. Get all bookmarks from old DB
  3. For loop
    1. Remove syncUUID
    2. Insert to new DB to Recovered Bookmarks folder

The restoration process can either happen automatically or through a setting option
@iccub iccub self-assigned this Nov 22, 2019
@iccub
Copy link
Contributor Author

iccub commented Nov 22, 2019 •
edited
Loading

Test note: It would be good to test it with various app states

  1. Normal browsing
  2. Private browsing only
  3. Normal browsing with pin code enabled
  4. WIth Sync enabled

@iccub iccub added this to the 1.14.1 milestone Dec 2, 2019
iccub added a commit that referenced this issue Dec 3, 2019
@iccub
Fix #2015: Restore bookmarks lost around 1.12-1.13 releases.
f57a084
@iccub iccub mentioned this issue Dec 3, 2019
Merged
7 tasks
iccub added a commit that referenced this issue Dec 3, 2019
@iccub
Fix #2015: Restore bookmarks lost around 1.12-1.13 releases.
618f48f
@jhreis jhreis modified the milestones: 1.14.1, 1.15 Dec 4, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.15, 1.14.2 Dec 4, 2019
This was referenced Dec 11, 2019
Closed
Closed
Closed
@jhreis jhreis closed this as completed in 18c480e Dec 11, 2019
@srirambv
Copy link
Contributor

srirambv commented Dec 11, 2019 •
edited by kjozwiak
Loading

Verification passed on iPhone X with iOS 13.2 running 1.14.2(19.12.9.17)

Verification passed on iPad Pro with iOS 13.2 running 1.14.2(19.12.9.17)

Verification PASSED on iPad Mini 4 running iOS 12.4.1 using 1.14.2 (19.12.11.21)

Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.14.2 (19.12.11.21)

@kjozwiak kjozwiak changed the title Provide an option to restore lost bookmarks during 1.12 migraiton Provide an option to restore lost bookmarks during 1.12 migration Dec 12, 2019
This was referenced Dec 12, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.14.2
Development

No branches or pull requests
5 participants
@kjozwiak @jhreis @iccub @anthonypkeane @srirambv