Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

publisher set custom tip amounts display out of order on banner #2177

Closed
LaurenWags opened this issue Jan 10, 2020 · 1 comment
Closed

publisher set custom tip amounts display out of order on banner #2177

LaurenWags opened this issue Jan 10, 2020 · 1 comment

Comments

@LaurenWags
Copy link
Member

Description:

When you open the tip banner for a verified publisher with custom tip amounts set, the tip amounts don't display from least to greatest (i.e. 5 BAT, 10 BAT, 20 BAT). They display mixed up.

However, if the publisher doesn't have custom tip amounts set, then the tip amounts display in order from least to greatest.

Steps to Reproduce

Below sites referenced are on Prod, if you need staging examples msg @LaurenWags

  1. Have Rewards enabled
  2. Visit a verified publisher without custom tip amounts set (ex. basicattentiontoken.org) and open tip banner
  3. See tip amounts in order 1 BAT, 5 BAT, 10 BAT.
  4. Visit a verified publisher with custom tip amounts set (ex. github.com/feross or rebron.org)

Actual result:
Tip amounts displayed out of order:
IMG_7E3C83FD2ED7-1

IMG_D6548E368495-1

Expected result:
tip amounts to be in order (least to greatest) when going left to right on the buttons:
IMG_C9E0CE394F14-1

Reproduces how often: [Easily reproduced, Intermittent Issue]
easily for custom tip amounts

Brave Version:
1.14.2 and 1.15

Device details:
iPad

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.4 running 1.15(20.02.12.10)

  • Verified publisher custom tip is ordered
    image

Verification passed on iPhone 7+ with iOS 13.3.1 running 1.15(20.02.12.10)

  • Verified publisher custom tip is ordered
    image

Verification passed on iPhone 6 with iOS 12.4.5 running 1.15(20.02.12.10)

  • Verified publisher custom tip is ordered
    image

Verification passed on iPad Pro with iOS 13.3.1 running 1.15(20.02.12.10)

  • Verified publisher custom tip is ordered
    image

Verification passed on iPad Pro with iOS 12.4.4 running 1.15(20.02.12.10)

  • Verified publisher custom tip is ordered
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants