Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

VPN switch is hidden in menu for translated text #3012

Closed
srirambv opened this issue Nov 5, 2020 · 4 comments · Fixed by #3233
Closed

VPN switch is hidden in menu for translated text #3012

srirambv opened this issue Nov 5, 2020 · 4 comments · Fixed by #3233

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2020

Description:

VPN switch is hidden in menu for translated text

Steps to Reproduce

  1. Set device locale to Russian
  2. Install any version and open menu
  3. VPN switch is not visible

Actual result:

Expected result:
Switch should be accessible

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.21(20.11.02.20)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

@iccub
Copy link
Contributor

iccub commented Nov 5, 2020

that string should be a DNT i believe, cc @anthonypkeane

@cperezabo
Copy link

cperezabo commented Jan 24, 2021

Same in Spanish
IMG_3811
Dear designer, in case you don't know, english is not the only language in the world, so why you design interfaces which only will work if the text is in english? 😒

@iccub
Copy link
Contributor

iccub commented Jan 25, 2021

Thanks for your report @cperezabo, this was a miscommunication with our translators.
This text should be never translated, otherwise there is not enough space for the toggle

@kjozwiak
Copy link
Member

  • Verification PASSED on iPhone 11 running iOS 14.4 using 1.23 (21.2.5.15)
Russian Spanish
IMG_3548 IMG_3549
  • Verification PASSED on iPad Air (3rd Gen) running iOS 14.4 using 1.23 (21.2.5.15)
French German
image image
  • Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.23 (21.2.5.15)
Japanese Thai
IMG_0452 IMG_0453
  • Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.23 (21.2.5.15)
Swedish South Korean
IMG_0110 IMG_0111

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants