Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[hackerone] #1068505 - URL parsing issue #3168

Closed
jumde opened this issue Dec 30, 2020 · 1 comment · Fixed by #3175
Closed

[hackerone] #1068505 - URL parsing issue #3168

jumde opened this issue Dec 30, 2020 · 1 comment · Fixed by #3175
Assignees
@jumde
Labels
bug Epic: Security QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@jumde
Copy link
Contributor

jumde commented Dec 30, 2020 •
edited
Loading

https://hackerone.com/bugs?report_id=1068505

Test Plan

Specified here: https://github.com/brave/security/issues/280
jumde added a commit that referenced this issue Jan 5, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
ef97797
@jumde jumde mentioned this issue Jan 5, 2021
Merged
7 tasks
jumde added a commit that referenced this issue Jan 5, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
b8476d5
jumde added a commit that referenced this issue Jan 5, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
d1e23ae
@jumde jumde self-assigned this Jan 5, 2021
@jumde jumde added this to the 1.23 milestone Jan 5, 2021
@jumde jumde added the bug label Jan 5, 2021
jumde added a commit that referenced this issue Jan 5, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
04ff142
jumde added a commit that referenced this issue Jan 5, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
dca04d4
jumde added a commit that referenced this issue Jan 6, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
93163e5
jumde added a commit that referenced this issue Jan 6, 2021
@jumde
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
3fc351c
jumde added a commit that referenced this issue Jan 7, 2021
@jumde
Merge pull request #3175 from brave/fix_3168
2a0ebb2 
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
iccub pushed a commit that referenced this issue Jan 12, 2021
@jumde @iccub
Merge pull request #3175 from brave/fix_3168
c0587f7 
Fix #3168: Update URLExtensions to allow parsing of truly fqdn
@kjozwiak
Copy link
Member

  • Verification PASSED on iPhone 11 running iOS 14.4 using 1.23 (21.2.5.15)
  • Verification PASSED on iPad Air (3rd Gen) running iOS 14.4 using 1.23 (21.2.5.15)
  • Verification PASSED on iPad Mini 4 running iOS 13.7 using 1.23 (21.2.5.15)
  • Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.23 (21.2.5.15)

Verification notes can be found via https://github.com/brave/security/issues/280#issuecomment-776412831.

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jumde jumde

Labels
bug Epic: Security QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #3168: Update URLExtensions to allow parsing of truly fqdn brave/brave-ios
3 participants
@jumde @kjozwiak @iccub