Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Modernize dependency management #3207

Closed
kylehickinson opened this issue Jan 18, 2021 · 2 comments · Fixed by #3191
Closed

Modernize dependency management #3207

kylehickinson opened this issue Jan 18, 2021 · 2 comments · Fixed by #3191
Assignees
@kylehickinson
Labels
enhancement Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.24

Comments

@kylehickinson
Copy link
Collaborator

Move away from Carthage for deps and move static libraries (.a) to modern XCFrameworks to ensure future Xcode compatibility

Test Plan

Dependencies may be updated in the process, therefore things that depend on them should be sanity tested.

This includes:

  • Image caching (i.e. large and small favicons)
  • Local web server (i.e. error pages, tab restore, etc.)
  • Animated Lottie images (onboarding)
  • Yubi Keys
  • SQLite passwords encryption
@kylehickinson kylehickinson added enhancement QA/Yes release-notes/exclude Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. labels Jan 18, 2021
@kylehickinson kylehickinson added this to the 1.24 milestone Jan 18, 2021
@kylehickinson kylehickinson self-assigned this Jan 18, 2021
@kylehickinson kylehickinson mentioned this issue Jan 18, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jan 27, 2021
@kylehickinson
Fix #3207: Migrate dependencies away from Carthage (#3191)
5328e30
This was referenced Mar 29, 2021
Closed
Closed
Closed
@kjozwiak
Copy link
Member

We'll label this as QA/Pass once all the issues have been verified and #3472, #3473 and #3474 have been completed.

@srirambv
Copy link
Contributor

srirambv commented Apr 1, 2021

Marking as passed based on previous comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.24
Development

Successfully merging a pull request may close this issue.

Fix #3207: Migrate dependencies away from Carthage brave/brave-ios
3 participants
@kylehickinson @kjozwiak @srirambv