Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Favourites show low resolution icons for some sites #463

Closed
srirambv opened this issue Nov 28, 2018 · 5 comments · Fixed by #611
Closed

Favourites show low resolution icons for some sites #463

srirambv opened this issue Nov 28, 2018 · 5 comments · Fixed by #611
Labels
bug QA/Yes release-notes/include
Milestone
1.10

Comments

@srirambv
Copy link
Contributor

Description:

Favourites show low resolution icons for some sites

Steps to Reproduce

  1. Visit https://quora in a new tab and add to favourites
  2. Open a new tab, shows low resolution image
  3. Add to bookmark, image doesn't look like low resolution because of small size

Actual result:
image from ios

FF
image from ios 1

Expected result:
Should look similar to FF

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.7(18.11.21.22)

Device details:
iPhone 7+ (iOS 12.1)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
danielbogomazov added a commit to danielbogomazov/brave-ios that referenced this issue Dec 9, 2018
@danielbogomazov
Fix brave#463: Use FaviconFetcher for favorites view icons
a7f2b41
@danielbogomazov danielbogomazov mentioned this issue Dec 9, 2018
Merged
6 tasks
jhreis pushed a commit that referenced this issue Mar 4, 2019
@danielbogomazov
Fix #463: Fixes resolution issue in the favorites view (#611)
1368a45
@srirambv srirambv added this to the 1.9 milestone Mar 13, 2019
This was referenced Mar 13, 2019
Closed
Closed
Closed
Closed
@LaurenWags
Copy link
Member

@jhreis some sites still show low res favicon, but it matches FF. Is this expected/ok? (see one below for Diablo III)
Image from iOS

@srirambv
Copy link
Contributor Author

assume the site favicon itself is of low resolution. Is that why its so pixelated?

@srirambv
Copy link
Contributor Author

Discussed with @jhreis regarding the issue. Moving to 1.10

@srirambv srirambv modified the milestones: 1.9, 1.10 Mar 27, 2019
@jhreis
Copy link
Contributor

jhreis commented Mar 27, 2019

We have a partial fix for this in 1.9, but apparently it was not good enough, we have additional work on this too for 1.10.

This was referenced Jul 10, 2019
Closed
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Jul 10, 2019 •
edited by LaurenWags
Loading

  • Verification passed on iPhone 7+ (iOS 12.3.1) running 1.10(19.07.08.19)
    File (1)

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.12.14)
    IMG_0B2BC62D62D1-1

This was referenced Jul 18, 2019
Closed
Closed
@srirambv srirambv mentioned this issue Jul 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug QA/Yes release-notes/include
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Fix #463: Fixes resolution issue in the favorites view danielbogomazov/brave-ios
4 participants
@kjozwiak @jhreis @srirambv @LaurenWags