Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Dropped transactions are never retired in our Wallet #5023

Closed
jamesmudgett opened this issue Feb 24, 2022 · 6 comments
Closed

Dropped transactions are never retired in our Wallet #5023

jamesmudgett opened this issue Feb 24, 2022 · 6 comments

Comments

@jamesmudgett
Copy link
Contributor

Same issue as seen on Desktop and Android brave/brave-browser#21051

We need to find a better way to communicate the following:

  • A pending transaction that is not going through (gas issue) is likely to prevent future send transactions from going through.
  • The failing pending transaction needs to be cancelled before a new one may be sent, or it will need to be completed.

Solution

Query the pending "submitted" transactions from the account which is trying to perform a new send during the validation checks. Update the messaging and link to pending list, something like, "We have detected a pending transaction that has not yet completed and will prevent this transaction from executing. View pending transactions"

@jamesmudgett
Copy link
Contributor Author

Will need to also query that the "Submitted" transaction are > 1day old (24hr)
Screen Shot 2022-02-24 at 11 50 06 AM

@bbondy
Copy link
Member

bbondy commented Feb 24, 2022

To clarify: If any "Submitted" transaction exists > 1 day old.

@bbondy
Copy link
Member

bbondy commented Feb 25, 2022

***That have not confirmed

iccub added a commit that referenced this issue Feb 25, 2022
This is so we can order translations before code for #5023 is ready.
iccub added a commit that referenced this issue Feb 25, 2022
This is so we can order translations before code for #5023 is ready.
iccub added a commit that referenced this issue Feb 25, 2022
This is so we can order translations before code for #5023 is ready.
@iccub iccub added this to the 1.36 milestone Feb 25, 2022
@iccub
Copy link
Contributor

iccub commented Feb 26, 2022

Copy from this ticket comment will be used brave/brave-browser#21051 (comment)

iccub added a commit that referenced this issue Feb 26, 2022
This is so we can order translations before code for #5023 is ready.
@iccub iccub removed this from the 1.36 milestone Mar 2, 2022
@nuo-xu
Copy link
Contributor

nuo-xu commented Mar 3, 2022

@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@nuo-xu
Copy link
Contributor

nuo-xu commented Mar 8, 2024

Close this issue since we have now handle transaction status Dropped updated from core. And a work around to pass that tx by editing nonce #

@nuo-xu nuo-xu closed this as completed Mar 8, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants