Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove edit option from search settings with no custom SE added. #5987

Closed
Uni-verse opened this issue Sep 7, 2022 · 1 comment · Fixed by #5990
Closed

Remove edit option from search settings with no custom SE added. #5987

Uni-verse opened this issue Sep 7, 2022 · 1 comment · Fixed by #5990
Assignees
@soner-yuksel
Labels
enhancement Epic: UI/UX QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.60

Comments

@Uni-verse
Copy link
Contributor

Description:

Makes sense to not display the edit option in search settings unless user adds custom SE url.

RPReplay_Final1662585559.MP4

Steps to Reproduce

  1. Clean install
  2. Navigate to menu > settings > Search Engines
  3. Observe edit option at top right corner of page

Brave Version:
version 1.43.x

Device details:
iPhone, iPad
@soner-yuksel soner-yuksel self-assigned this Sep 8, 2022
@soner-yuksel soner-yuksel mentioned this issue Sep 8, 2022
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Sep 12, 2022
@soner-yuksel
Fix #5987: Remove edit option from search settings with no custom SE (#…
33cbd3f 
…5990)
@iccub iccub added this to the 1.59 milestone Oct 6, 2023
@Uni-verse
Copy link
Contributor Author

Verified on iPhone X running iOS 16.7 using version 1.60 (23.11.9.15)

  • Ensured that Edit option is not shown in Search Engines settings page when custom search engines are not added.
  • Ensured Edit option is displayed after adding custom SE and also removed when deleting custom SE.
Example Example Example
IMG_3624 2 IMG_3625 2 IMG_3626 2

@Uni-verse Uni-verse mentioned this issue Dec 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: UI/UX QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.60
Development

Successfully merging a pull request may close this issue.

Fix #5987: Remove edit option from search settings with no custom SE brave/brave-ios
3 participants
@soner-yuksel @iccub @Uni-verse