Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

NTP SI on iOS does not respect wallpaper specific logo overrides #6015

Closed
kylehickinson opened this issue Sep 14, 2022 · 1 comment · Fixed by #6016
Closed

NTP SI on iOS does not respect wallpaper specific logo overrides #6015

kylehickinson opened this issue Sep 14, 2022 · 1 comment · Fixed by #6016

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Sep 14, 2022

Description:

When there's a specific logo passed in with a NTP SI logo it is not shown and instead the main campaign logo is always shown

Steps to Reproduce:

On Brave Dev (staging campaigns) open tabs until you begin to see NTP SI's. They will rotate through 3 different Brave Search campaigns.

Expected:

SI #1 - Woman walking away from camera, logo text is “Logo “Private, independent, & open. Search without a trace.” it should link to https://search.brave.com/?source=Private-Independent-Open-Search-Without-A-Trace
SI #2 - Woman walking with dog away from the camera, logo text is “Private, independent, & open. The search engine that doesn’t track you.” It should link to https://search.brave.com/?source=Private-Independent-Open-The-Search-Engine-That-Doesn't-Track-You
SI #3 - Logo text is “Explore freely with our unbiased, private search engine.” It should link to https://search.brave.com/?source=Explore-Freely (Same background as SI #1 but different logo and URL.)

Actual:

You only see the main campaign logo regardless of wallpaper which has the logo "Private, independent, & open. Search without a trace"

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 13, 2022

Testing in Progress using Brave Dev 1.44 (22.10.13.13) using the following device(s):

iPhone 12 | iOS 16.x
iPhone XR | iOS 15.x
iPhone X | iOS 14.x
iPad | iOS 15.x

SI 1 (Girl walking away from camera)

Example Example
IMG_0107 IMG_0104

SI 2 - (Woman walking with dog away from the camera)

Example Example
IMG_0105 IMG_0106

SI 3

Example Example
IMG_0108 IMG_0109

iPad

SI 1 SI 2 SI 3
IMG_0662 IMG_0663 IMG_0664

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants