Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Status bar (time, LTE, Wifi. Battery) always has a "white color" when "Reader Mode" is ON and "Bottom Bar" is ON #7673

Closed
hffvld opened this issue Jun 30, 2023 · 1 comment · Fixed by #7716
Closed

Status bar (time, LTE, Wifi. Battery) always has a "white color" when "Reader Mode" is ON and "Bottom Bar" is ON #7673

hffvld opened this issue Jun 30, 2023 · 1 comment · Fixed by #7716
Assignees
@kylehickinson
Labels
bug Epic: Reader-mode OS/iOS QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.56

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jun 30, 2023 •
edited
Loading

Description:

Status bar (time, LTE, Wifi. Battery) always has white color when Reader Mode is ON and Bottom Bar is ON

Steps to Reproduce

  1. Launch Brave > Three-dot menu > Settings
  2. Scroll down and make sure Bottom Bar is ON
  3. Now open, for example, www.wikipedia.org > Then open any article
  4. Tap Reader Mode button in a search bar > Observe

Actual result:

Status bar (time, LTE, Wifi. Battery) always has a white color when Reader Mode is ON and Bottom Bar is ON. If Top Bar is ON, then the Status bar has the same color as Brave UI.

Top Bar is ON Reader Mode is OFF Reader Mode is ON
1 2 3
Bottom Bar is ON Reader Mode is OFF Reader Mode is ON
1 2 3

Expected result:

Status bar (time, LTE, Wifi. Battery) must match the color of Brave UI when Reader Mode is ON.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.52 (23.6.30.11)
BraveCore: 1.52.129 (114.0.5735.198)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone 14 [iOS 16.5.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
kylehickinson added a commit that referenced this issue Jul 11, 2023
@kylehickinson
Fix #7673: Update the status bar overlay appropriately on internal pages
8f319a3
@kylehickinson kylehickinson mentioned this issue Jul 11, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Jul 11, 2023
@kylehickinson
Fix #7673: Update the status bar overlay appropriately on internal pages
2795148
kylehickinson added a commit that referenced this issue Jul 11, 2023
@kylehickinson
Fix #7673: Update the status bar overlay appropriately on internal pages
ad1c132
@kylehickinson kylehickinson added this to the 1.56 milestone Jul 11, 2023
kylehickinson added a commit that referenced this issue Jul 11, 2023
@kylehickinson
Fix #7673: Update the status bar overlay appropriately on internal pa…
51c47af 
…ges (#7716)
@hffvld hffvld changed the title Status bar (time, LTE, Wifi. Battery) always has a "white color" when "Reader Mode" is enabled and "Top Bar" is ON Status bar (time, LTE, Wifi. Battery) always has a "white color" when "Reader Mode" is ON and "Bottom Bar" is ON Jul 18, 2023
@hffvld
Copy link
Collaborator Author

hffvld commented Jul 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.18.21)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave > Three-dot menu > Settings
  2. Scroll down and make sure Bottom Bar is ON
  3. Now open, for example, www.wikipedia.org > Then open any article
  4. Tap Reader Mode button in a search bar > Observe

ACTUAL RESULTS:

  • Verified that Status bar (time, LTE, Wifi. Battery) is matching the color of Brave UI when Reader Mode is ON.
Top Bar Reader Mode is OFF Reader Mode is ON
1 2 3
Bottom Bar Reader Mode is OFF Reader Mode is ON
1 2 3

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7673: Update the status bar overlay appropriately…
e3c305b 
… on internal pages (brave/brave-ios#7716)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Reader-mode OS/iOS QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7673: Update the status bar overlay appropriately on internal pages brave/brave-ios
3 participants
@kylehickinson @Uni-verse @hffvld