Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Reader mode bar background color doesn't match night mode & private mode #7717

Closed
kylehickinson opened this issue Jul 11, 2023 · 1 comment · Fixed by #7936
Closed

Reader mode bar background color doesn't match night mode & private mode #7717

kylehickinson opened this issue Jul 11, 2023 · 1 comment · Fixed by #7936

Comments

@kylehickinson
Copy link
Collaborator

Description:

The reader mode bar background color uses the light or dark url bar background color regardless of night mode or private mode state.

Steps to Reproduce

  1. Open a wikipedia page and activate reader mode
  2. Turn on night mode or private mode

Actual result:

The reader mode bar at the top of the page does not match the url bar background color

Private Mode Night Mode
Simulator Screenshot - iPhone 14 Pro - 2023-07-11 at 14 56 54 Simulator Screenshot - iPhone 14 Pro - 2023-07-11 at 14 56 45

Expected result:

Should match

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator

hffvld commented Sep 19, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.19.14)
BraveCore: 1.58.124 (117.0.5938.62)

Standard Tab

STEPS:

  1. Launch Brave
  2. Open the Wikipedia website > Tap Reader Mode button in the URL search bar > Verify UI color
  3. Three-dot menu > Night Mode > Verify UI color
  4. Tree-dot menu > Settings > TABS > Enable Top Bar
  5. Return to Wikipedia > Verify UI with and without Night Mode again

ACTUAL RESULTS:

  • Verified that UI color has proper color with and without Night Mode
  • Verified above behavior with Top Bar and Bottom Bar

Bottom Bar, no Night Mode Bottom Bar with, Night Mode Top Bar, no Night Mode Top Bar with, Night Mode
1 2 3 4
Private Tab

STEPS:

  1. Launch Brave
  2. Tap Tab switch button > Private > + button
  3. Open the Wikipedia website > Tap Reader Mode button in the URL search bar > Verify UI color
  4. Three-dot menu > Night Mode > Verify UI color
  5. Tree-dot menu > Settings > TABS > Enable Top Bar
  6. Return to Wikipedia > Verify UI with and without Night Mode again

ACTUAL RESULTS:

  • Verified that UI color has proper color with and without Night Mode (In a Private Mode it has the same color)
  • Verified above behavior with Top Bar and Bottom Bar

Bottom Bar, no Night Mode Bottom Bar with, Night Mode Top Bar, no Night Mode Top Bar with, Night Mode
1 2 3 4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants