Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add Haptic Feedback Voice Search for successful query #7798

Closed
soner-yuksel opened this issue Jul 28, 2023 · 1 comment · Fixed by #7800
Closed

Add Haptic Feedback Voice Search for successful query #7798

soner-yuksel opened this issue Jul 28, 2023 · 1 comment · Fixed by #7800
Assignees
@soner-yuksel
Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57

Comments

@soner-yuksel
Copy link
Contributor

Description:

Add a haptic feedback (vibration sounds and impact feedback) for successful voice search entry
@soner-yuksel soner-yuksel added this to the 1.57 milestone Jul 28, 2023
@soner-yuksel soner-yuksel self-assigned this Jul 28, 2023
@soner-yuksel soner-yuksel changed the title Add Haptic Feedback Voice Search for succesful query Add Haptic Feedback Voice Search for successful query Jul 28, 2023
@soner-yuksel soner-yuksel mentioned this issue Jul 28, 2023
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Jul 31, 2023
@soner-yuksel
Fix #7798: Add Haptic Feedback Voice Search for successful query (#7800)
31d58fb
@hffvld
Copy link
Collaborator

hffvld commented Aug 24, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.57 (23.8.23.20)
BraveCore: 1.57.53 (116.0.5845.114)

STEPS:

  1. Launch Brave
  2. NTP > Tap in the URL search bar
  3. Invoke Voice search > Ask some query
  4. Wait until the search flow is done > Verify

ACTUAL RESULTS:

  • Verified that Voice search is working (no regression)
  • Verified that haptic feedback is triggered after a successful voice search

I'm not sure how to record the video with haptic feedback representation :)

Voice.search.mov

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#7798: Add Haptic Feedback Voice Search for succes…
02ca13b 
…sful query (brave/brave-ios#7800)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7798: Add Haptic Feedback Voice Search for successful query brave/brave-ios
3 participants
@soner-yuksel @Uni-verse @hffvld