Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Only show Playlist "Storage almost full" message once per day #7869

Closed
ahmed-shehata opened this issue Aug 11, 2023 · 1 comment
Closed

Only show Playlist "Storage almost full" message once per day #7869

ahmed-shehata opened this issue Aug 11, 2023 · 1 comment
Labels
enhancement feature-request QA/No release-notes/include
Milestone
1.58

Comments

@ahmed-shehata
Copy link
Contributor

ahmed-shehata commented Aug 11, 2023 •
edited
Loading

Problem Description

"Storage almost full" message keeps appearing every time an item is added to playlist. I believe it should only show at most once per day.

Feature Overview

The popup's nag is pretty annoying for frequent users of the Playlist feature.

Design

image

Implementation Details

#7870

User Experience

  1. Have low disk space
  2. Add video to playlist
  3. See popup for low disk space only once per day (24 hrs)

Additional information
@ahmed-shehata ahmed-shehata mentioned this issue Aug 11, 2023
Merged
11 tasks
@hkarmoush
Copy link
Contributor

Does it make sense to persist a dictionary in UserDefaults? the key being the DateTime object for each day and a boolean value determined upon the popup dismissal?

@iccub iccub closed this as completed in 748990d Aug 22, 2023
@iccub iccub added this to the 1.58 milestone Aug 23, 2023
@Uni-verse Uni-verse mentioned this issue Nov 27, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@ahmed-shehata
Fix brave/brave-ios#7869: Add check for "storage almost full" for onc…
1a97e16 
…e per app launch (brave/brave-ios#7870)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement feature-request QA/No release-notes/include
Projects
None yet
Milestone
1.58
Development

No branches or pull requests
4 participants
@ahmed-shehata @iccub @Uni-verse @hkarmoush