Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up to #8045] Notification asking to set Brave as the default browser is still shown after an external link opened via the 3P app #8163

Closed
hffvld opened this issue Sep 26, 2023 · 2 comments · Fixed by #8186

Comments

@hffvld
Copy link
Collaborator

hffvld commented Sep 26, 2023

Description:

Follow-up to #8045

Steps to Reproduce

  1. Launch Brave
  2. Go through onboarding and don't set it as Default browser
  3. Launch Gmail > Open a link with Brave
  4. Go to device settings > Update time on 2 hours forward
  5. Check notification > Observe

Actual result:

Observed that notification asking to set Brave as the default browser is still shown after an external link opened via the 3P app

notif_funct.mp4

Expected result:

Notification must not be shown if an external link is opened via 3P app, like Gmail or Slack.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.58 (23.9.26.17)
BraveCore: 1.58.129 (117.0.5938.88)

  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 17.0]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@Uni-verse
Copy link
Contributor

Reproducible on iPhone X running iOS 16.5.1 using STR in description.

0

@hffvld
Copy link
Collaborator Author

hffvld commented Oct 6, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.1]
Brave build: 1.58 (23.10.6.14)
BraveCore: 1.58.139 (117.0.5938.153)

STEPS:

  1. Follow the steps from Fix 8163: Notification asking to set Brave as the default browser is still shown after an external link opened via the 3P app #8186 (comment)

ACTUAL RESULTS:

  • Verified that notification is not shown if an external link is opened via 3P app, like Gmail.

2023-10-06_13-27-01.mp4
2023-10-06_13-31-20.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.