Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Default Browser Notification - Update (Text - Default Logic) #8045

Closed
anthonypkeane opened this issue Sep 11, 2023 · 2 comments · Fixed by #8067
Closed

Default Browser Notification - Update (Text - Default Logic) #8045

anthonypkeane opened this issue Sep 11, 2023 · 2 comments · Fixed by #8067

Comments

@anthonypkeane
Copy link

Description:

https://old.reddit.com/r/brave_browser/comments/16ft2w2/brave_browser_sending_notifications_to_set/

Related: #7860

Please update this notification and don't show if
--> Remove if one external url is opened(via mail app, notes, other apps...)

Also, update the text as following (pending @rmcfadden3 approval)

Title: "Enhance Your Privacy with Brave"
Subtitle: "Protect your data – Set Brave as your default browser."

@rmcfadden3
Copy link

Maybe something like:

Header: Get Brave protection, on every link
Body: Set Brave as your default browser

@hffvld
Copy link
Collaborator

hffvld commented Sep 26, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.22.13)
BraveCore: 1.58.129 (117.0.5938.88)

Filed follow-up issue #8163

Notification. Updated strings.

STEPS:

  1. Launch Brave
  2. Go through onboarding and don't set it as Default browser
  3. Go to device settings > Update time on 2 hours forward
  4. Pull down the notification drawer > Verify

ACTUAL RESULTS:

  • Verified that notification to set Brave as default browser is shown in 2 hours after Brave installation
  • Verified updated strings in the notification:
    • Title: Get Brave protection, on every link
    • Body: Set Brave as your default browser

1 2 3
1 2 3
notif.mp4
Notification. Functionality.

STEPS:

  1. Launch Brave
  2. Go through onboarding and don't set it as Default browser
  3. Launch Gmail > Open a link with Brave
  4. Go to device settings > Update time on 2 hours forward
  5. Check notification > Verify

ACTUAL RESULTS:

  • Verify that notification must not be shown after an external link is opened via Gmail or another 3P app
  • Observed that notification is still shown after an external link was opened via Gmail

2023-09-26_12-16-29.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.