Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Default Browser Prompt NTP - Logic Change #7860

Closed
anthonypkeane opened this issue Aug 9, 2023 · 1 comment · Fixed by #7892
Closed

Default Browser Prompt NTP - Logic Change #7860

anthonypkeane opened this issue Aug 9, 2023 · 1 comment · Fixed by #7892

Comments

@anthonypkeane
Copy link

anthonypkeane commented Aug 9, 2023

Description:

Slack: https://bravesoftware.slack.com/archives/G01F4JUNXAQ/p1691614643386869

Please update the Make Default prompt with the following criteria

  • Remove if one external url is opened(via mail app, notes, other apps...)
  • Don't show for 7 days after install
  • Never show over an NPT SI
  • Stop showing it after 14 days since install

iOS Make Default

@anthonypkeane anthonypkeane added this to the 1.57 milestone Aug 9, 2023
@soner-yuksel soner-yuksel self-assigned this Aug 16, 2023
@soner-yuksel soner-yuksel changed the title Make Default prompt - logic update Default Browser Prompt NTP - Logic Change Aug 17, 2023
@hffvld
Copy link
Collaborator

hffvld commented Aug 26, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.57 (23.8.28.13)
BraveCore: 1.57.53 (116.0.5845.114)Brave build: 1.57 (23.8.28.13)
BraveCore: 1.57.53 (116.0.5845.114)

Filled follow-up issue #7969 and #7977

Don't show for 7 days after installation

STEPS:

  1. Fresh install and launch Brave
  2. Start onboarding flow > Don't set Brave as the default browser and select Not now
  3. Tap Done > Wait until landed on NTP > Verify
  4. Go to device settings and update the date to be less than 7 days from today
  5. Close and relaunch Brave > Verify
  6. Change the date to be 8 days after Brave installed > Relaunch Brave > Verify
  7. Tap on Default browser prompt > Verify

ACTUAL RESULTS:

  • Verified that Default browser prompt is not shown on NTP after a fresh install
  • Verified that Default browser prompt is not shown on NTP when it's less than 7 days after Brave installed
  • Verified that Default browser prompt is shown after 7 days since Brave installed
  • Verified, that tapping on Default browser prompt is opening device settings for the default browser setup, and going back to Brave is not showing Default browser prompt anymore
  • Verified that no regression occurred and if Brave is set as the default browser, Default browser prompt is not shown after a fresh install or after 7 days

1 2
1 2
1 2

Brave is not set as default

Default_7.days.mov

Brave is set as default

Default.set_7.days.mov
Remove if one external URL is opened (via mail app, notes, other apps...)

STEPS:

  1. Fresh install and launch Brave
  2. Start onboarding flow > Don't set Brave as the default browser and select Not now
  3. Tap Done > Wait until landed on NTP > Confirm there is no Default browser prompt is shown
  4. Go to device settings and update the date to be 8 days from today
  5. Close and relaunch Brave > Confirm that Default browser prompt is shown
  6. Open email, notes, messenger, etc > Open any link in Brave
  7. Open NTP > Verify

ACTUAL RESULTS:

  • Verified that Default browser prompt is removed and not shown anymore when an external URL is opened in Brave

default.off_external.url.mov
Never show over an NTP SI

STEPS:

  1. Fresh install and launch Brave
  2. Start onboarding flow > Don't set Brave as the default browser and select Not now
  3. Tap Done > Wait until landed on NTP > Confirm there is no Default browser prompt is shown
  4. Go to device settings and update the date to be 8 days from today
  5. Close and relaunch Brave > Confirm that Default browser prompt is shown
  6. Open another NTP until you see SI page > Verify

ACTUAL RESULTS:

  • Verified that Default browser prompt must not be shown on NTP with SI
  • Verified that Default browser prompt is shown on a regular NTP

1 2 3
1 2 3
NTP.SI_empty.mov
Stop showing it after 14 days since installation

STEPS:

  1. Fresh install and launch Brave
  2. Start onboarding flow > Don't set Brave as the default browser and select Not now
  3. Tap Done > Wait until landed on NTP > Confirm there is no Default browser prompt is shown
  4. Device Settings > Update the date to be <7 days from today
  5. Relaunch Brave > Confirm there is no Default browser prompt on NTP
  6. Now update the date between 7 and 14 days from today
  7. Relaunch Brave > Confirm that Default browser prompt is shown on NTP
  8. Now update the date to be>14 days from today
  9. Relaunch Brave > Verify

ACTUAL RESULTS:

  • Verified that Default browser prompt must not be shown on NTP after 14 days since installation

default_14days_720.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants