Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7969: [Follow up to #7860] Data on NTP with SI is not aligned properly #7975

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 28, 2023

Summary of Changes

Fixing should show NTP callouts on for default browsing on SI

This pull request fixes #7969

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Fresh install and launch Brave
  • Start onboarding flow > Don't set Brave as the default browser and select Not now
  • Tap Done > Wait until landed on NTP > Confirm there is no Default browser prompt is shown
  • Go to device settings and update the date to be 8 days from today
  • Close and relaunch Brave > Confirm that Default browser prompt is shown on regular NTP
  • Open another NTP until you see SI page > Observe

Screenshots:

RPReplay_Final1694195839.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 28, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 28, 2023 18:00
@soner-yuksel soner-yuksel self-assigned this Aug 28, 2023
@soner-yuksel soner-yuksel merged commit 1f3e1a7 into development Aug 28, 2023
7 checks passed
@soner-yuksel soner-yuksel deleted the fix/default-browser-si branch August 28, 2023 18:48
iccub pushed a commit that referenced this pull request Aug 28, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #7860] Data on NTP with SI is not aligned properly
2 participants