Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up to #7860] Data on NTP with SI is not aligned properly #7969

Closed
hffvld opened this issue Aug 26, 2023 · 1 comment · Fixed by #7975
Closed

[Follow up to #7860] Data on NTP with SI is not aligned properly #7969

hffvld opened this issue Aug 26, 2023 · 1 comment · Fixed by #7975

Comments

@hffvld
Copy link
Collaborator

hffvld commented Aug 26, 2023

Description:

Follow-up to #7860

Steps to Reproduce

  1. Fresh install and launch Brave
  2. Start onboarding flow > Don't set Brave as the default browser and select Not now
  3. Tap Done > Wait until landed on NTP > Confirm there is no Default browser prompt is shown
  4. Go to device settings and update the date to be 8 days from today
  5. Close and relaunch Brave > Confirm that Default browser prompt is shown on regular NTP
  6. Open another NTP until you see SI page > Observe

Actual result:

Observed that NTP with SI is empty, there is no info shown on it. I tried to move around and found that all the data was there, but it was on the far left. Looks like it's not aligned correctly. When Default browser prompt is hidden, this issue does not happen.

1 2 3
1 2 3
NTP.SI_empty.mov

Expected result:

All info on NTP with SI when Default browser prompt is shown must be properly aligned.

2023-08-25_17-07-25

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.57 (23.8.25.21)
BraveCore: 1.57.53 (116.0.5845.114)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes. Build 1.57 (23.8.18.14) and newer
  • Can you reproduce this issue with the current build from AppStore? No

Device details:

iPhone 14 [iOS 17.0]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator Author

hffvld commented Aug 28, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.0]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57 (23.8.28.13)
BraveCore: 1.57.53 (116.0.5845.114)

STEPS:
Followed the steps from #7969 (comment)

ACTUAL RESULTS:

  • Verified that Default browser prompt is not shown on NTP SI
  • Verified that all info on NTP Si is aligned and shown correctly

iPhone

1 2
1 2
Default_NTP.SI_.alignment_ios.mov

iPad

1 2
1 2
Default_ipad_1080.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.