Address bar moves to the wrong position

[A-t-s-u-s-h-i]

Description:

After updating to v1.58.2, sometimes address bar moves to top even though I set it on bottom. I haven't found the specific procedure to replicate. But the issue sometimes happens after operating Playlist.

Steps to Reproduce

1. Set the address bar on the bottom
2. Using Playlist for a while
3. Coming back to the browser screen

Actual result:

Sometimes address bar is shown on the top

(screenvideo)
https://github.com/brave/brave-ios/assets/79502386/66c345e5-c576-4760-a7da-db9a7d65b725

Expected result:

The browser shows address bar on the bottom.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Intermittent Issue

Brave Version:

1.58.2(23.11.3.10)

• Can you reproduce this issue with the most recent build from TestFlight?
  Not reproduced yet

• Can you reproduce this issue with the previous version of the current build from TestFlight?
  Untested

• Can you reproduce this issue with the current build from AppStore?
  Yes

Device details:

iPhone13 Pro/iOS17.1

Additional Information

[Uni-verse]

I have observed 2-3 instances of this so far on iPhone 12 (iOS 17.0.3) using 1.58.2 version. I don't have steps but I noticed this was happening when performing the following operations.

1. Viewing videos full screen landscape in Playlist and then returning to tab (YT).
2. Switching between Brave and other apps using task switcher / re-launching Brave.

[kylehickinson]

Based on the video it doesn't look like you're actually switching to top bar, but the app somehow thinking its in landscape mode and displaying the landscape toolbar which is always on top so I guess it would make sense that it somehow triggered when viewing things in landscape… would have to investigate why though because afaik nothing has changed in 1.58 hotfixs around the main layout. I'd assume this is present in regular 1.58 builds as well?

[Uni-verse]

Based on the video it doesn't look like you're actually switching to top bar, but the app somehow thinking its in landscape mode and displaying the landscape toolbar which is always on top so I guess it would make sense that it somehow triggered when viewing things in landscape… would have to investigate why though because afaik nothing has changed in 1.58 hotfixs around the main layout. I'd assume this is present in regular 1.58 builds as well?

I personally have not encountered it on 1.58 but It makes sense.

[kylehickinson]

Closing in favor of #8421