Device removed when offline doesn't get removed from the sync chain

[srirambv]

Description:

Device removed when offline doesn't get removed from the sync chain

Devices

Device 1: iPhone 7+
Device 2: iPhone 6

Steps to Reproduce

1. Create sync chain on device 1
2. Sync device 2 using QR code, ensure both devices are listed in each other
3. Put device 1 on offline mode, remove device 1 from sync chain on device 1
4. Sync device 1 again to the sync chain by scanning QR code on device 2
5. Both devices show device 1 twice

Actual result:
Device removed when offline doesn't get removed from the sync chain

Expected result:
Changes made offline should propagate when devices are online

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.9 (19.02.03.15)

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

[LaurenWags]

Verified passed with 1.9 (19.03.25.21) on iPad 5th Gen using STR from description. Was unable to remove a device from sync chain when in offline mode.

Verified passed with 1.9 (19.03.25.21) on iPhone 8 using STR from the description. Step 3 - was unable to remove a device from sync chain when the device is in offline mode.

Verification passed on iPhone 7+/ iPhone 6 and iPad Pro all running 1.9(19.3.25.21). Trying to remove sync during offline shows the error message
iPad Pro

iPhone 6

iPhone 7+

• Verification PASSED with 1.9 (19.3.27.19) on iPad Mini 4 using the above STR. Was unable to remove a device from sync chain when device was offline.