Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bookmark with empty title from desktop doesn't update on iOS #992

Closed
iccub opened this issue Mar 20, 2019 · 3 comments
Closed

Bookmark with empty title from desktop doesn't update on iOS #992

iccub opened this issue Mar 20, 2019 · 3 comments

Comments

@iccub
Copy link
Contributor

iccub commented Mar 20, 2019

Description:

Steps to Reproduce

  1. Pair iOS device and desktop
  2. Add a bookmark on desktop
  3. Edit the bookmark to have empty title, so only favicon is visible

Actual result:
Title doesn't get updated on iOS

Expected result:
Title should update on iOS

Reproduces how often: [Easily reproduced, Intermittent Issue]
100%

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@LaurenWags
Copy link
Member

@iccub I'm a little unclear on the expected result here. It looks like the title did update when viewed in Edit Mode:
syncedbkmk-editmode

But when viewing the bookmark in regular (non-edit) mode, I see the URL. Is this expected?
syncedbookmark

@iccub
Copy link
Contributor Author

iccub commented Mar 26, 2019

@LaurenWags On bookmark panel we show displayTitle which means if no title is provided, bookmark's url is presented.
In edit mode you can of course edit both name and the url.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 26, 2019

  • Verified passed with 1.9 (19.03.25.21) on iPad 5th Gen
  • Verified passed with 1.9 (19.03.25.21) on iPhone 8
  • Verification passed on iPhone 6/7 and iPad Pro running 1.9(19.3.25.21)
  • Verification passed on iPhone SE running 1.9 (19.3.25.21)
  • Verification PASSED with 1.9 (19.3.27.19) on iPad Mini 4 using the above STR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants