Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fixed clearing of all Tabs and Data in Private-Browsing-Only #1382

Merged
merged 5 commits into from
Nov 14, 2019
Merged

Fixed clearing of all Tabs and Data in Private-Browsing-Only #1382

merged 5 commits into from
Nov 14, 2019

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Aug 12, 2019 •
edited by jhreis
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

Screenshots:

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable)

@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 2 times, most recently from e7e4754 to 62c4f36 Compare August 13, 2019 23:28
iccub
iccub suggested changes Aug 14, 2019
View reviewed changes
Data/models/TabMO.swift Outdated Show resolved Hide resolved
Client/Frontend/Browser/BrowserViewController.swift Outdated Show resolved Hide resolved
Client/Frontend/Browser/BrowserViewController.swift Outdated Show resolved Hide resolved
iccub
iccub approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I would like to get this reviewed by @danishjafri88 as well, as he's done a bit of similar data-clearing work

@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch from a03cc97 to 2151639 Compare August 15, 2019 14:58
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch from b9e7791 to 7df91a0 Compare August 22, 2019 13:35
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 2 times, most recently from 57e3338 to f21c140 Compare August 23, 2019 03:53
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch from f21c140 to 480b3c3 Compare September 9, 2019 19:22
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 3 times, most recently from 9a59d4b to 27200f5 Compare October 7, 2019 13:45
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch from 27200f5 to dfac35d Compare October 8, 2019 15:03
@Brandon-T Brandon-T requested a review from jhreis October 8, 2019 15:05
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 5 times, most recently from ab6adaa to 74fe6f1 Compare October 15, 2019 15:25
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 3 times, most recently from e8a39c8 to c846aa8 Compare October 16, 2019 14:59
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch 3 times, most recently from 1528c1b to 0f7d94b Compare November 8, 2019 19:22
@Brandon-T Brandon-T force-pushed the feature/PrivateBrowsingOnly branch from 0f7d94b to 82c1067 Compare November 14, 2019 16:38
@jhreis jhreis merged commit 3306693 into development Nov 14, 2019
@jhreis jhreis deleted the feature/PrivateBrowsingOnly branch November 14, 2019 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@danishjafri88 danishjafri88 danishjafri88 approved these changes

@jhreis jhreis jhreis approved these changes

@kylehickinson kylehickinson Awaiting requested review from kylehickinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Not Restoring Tabs when Disabling PBO
5 participants
@Brandon-T @kylehickinson @jhreis @danishjafri88 @iccub