Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #2041 - Session storage not clearing when toggling the PBO switch. #2322

Merged
merged 7 commits into from
Aug 5, 2020
Merged

Fix #2041 - Session storage not clearing when toggling the PBO switch. #2322

merged 7 commits into from
Aug 5, 2020

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Feb 12, 2020 •
edited by iccub
Loading

Summary of Changes

  • Fixes session storage not being cleared due to a race-condition in WKWebsiteDataStore.
  • Also added a popup UI to block the user from toggling the switch back & forth until the data has actually been cleared.

This pull request fixes issue #2041

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

STR in the ticket

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T force-pushed the bugfix/SessionStorage branch from 9e5908b to c1a6377 Compare June 15, 2020 15:21
@Brandon-T Brandon-T requested review from kylehickinson and removed request for jhreis June 15, 2020 15:23
@Brandon-T Brandon-T force-pushed the bugfix/SessionStorage branch from c1a6377 to d3b47ad Compare June 30, 2020 15:13
@Brandon-T Brandon-T force-pushed the bugfix/SessionStorage branch 3 times, most recently from 92e1081 to d9fe2b6 Compare July 3, 2020 13:14
@iccub iccub linked an issue Jul 9, 2020 that may be closed by this pull request
Session is retained when PBO is setting is toggled [Follow up to 1987] #2041
Closed
@iccub iccub mentioned this pull request Jul 29, 2020
Closed
@Brandon-T Brandon-T force-pushed the bugfix/SessionStorage branch from d9fe2b6 to 638ec5e Compare July 31, 2020 14:50
@Brandon-T Brandon-T requested a review from kylehickinson July 31, 2020 15:07
@iccub iccub merged commit 8c9ca84 into development Aug 5, 2020
@iccub iccub deleted the bugfix/SessionStorage branch August 5, 2020 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session is retained when PBO is setting is toggled [Follow up to 1987]
3 participants
@Brandon-T @kylehickinson @iccub