This repository has been archived by the owner on May 10, 2024. It is now read-only.
Implement out of band updates for Brave Ads #2712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
suggested changes
Jul 9, 2020
| brave-core: master (a0bb7d59ed3d0695df46f3e25ec9e53cf8881a97) | ||
| latest tag: v1.12.77 | ||
| brave-browser: master (581b9cde2d15d5cffc8aa9eea1472f9171e3c707) | ||
| brave-core: issues/8396 (96586ef16c2bcdabb2d62b019f763c8ecdf1bb1c) |
There was a problem hiding this comment.
This will have to be built from master before it can be merged
kylehickinson
added
the
blocked
|
Have to wait until brave/brave-core#5209 is merged |
kylehickinson
force-pushed
the
brave-core-1.13.x
branch
2 times, most recently
from
db9ea62
to
4eb7b2c
Compare
tmancey
force-pushed
the
brave-core-1.13.x-ios-out-of-band-user-model-updates
branch
from
d6a894f
to
43fade9
Compare
|
Changes only exist in BraveRewards.framework so closing as this will be closed |
kylehickinson
deleted the
brave-core-1.13.x-ios-out-of-band-user-model-updates
branch
kylehickinson
restored the
brave-core-1.13.x-ios-out-of-band-user-model-updates
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #2707
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement