Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix 2952: Show about:blank for empty window.open #2978

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix 2952: Show about:blank for empty window.open #2978

merged 1 commit into from
Nov 30, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 19, 2020 •
edited by iccub
Loading

Summary of Changes

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Specified here: https://github.com/brave/security/issues/244

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@jumde jumde self-assigned this Oct 19, 2020
@jumde jumde requested review from iccub, kylehickinson and Brandon-T and removed request for iccub and kylehickinson October 19, 2020 23:19
@jumde jumde added this to the 1.23 milestone Oct 19, 2020
@iccub iccub merged commit bda2f94 into development Nov 30, 2020
@iccub iccub deleted the fix_2952 branch November 30, 2020 17:02
@kylehickinson kylehickinson removed this from the 1.23 milestone Feb 1, 2021
@kjozwiak kjozwiak added this to the 1.23 milestone Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@Brandon-T Brandon-T Awaiting requested review from Brandon-T

@kylehickinson kylehickinson Awaiting requested review from kylehickinson

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.

[upstream/firefox-ios][hackerone] #1634597 - about:blank spoofing
4 participants
@jumde @kylehickinson @iccub @kjozwiak