Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3650 - Fix Playlist losing track of time when backgrounding or leaving the screen #3692

Merged
merged 1 commit into from
May 20, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented May 18, 2021

Summary of Changes

  • Fix Playlist losing track of time when backgrounding the app or leaving the screen.
  • Added observers for termination & backgrounding
  • Added observer for item status to know when to seek to the correct playback time due to player race condition.

This pull request fixes #3650

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.27 milestone May 20, 2021
@Brandon-T Brandon-T merged commit 75fc1ee into development May 20, 2021
@Brandon-T Brandon-T deleted the bugfix/Backgrounding branch May 20, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist loses position of current video when you leave/come back
3 participants