This repository has been archived by the owner on May 10, 2024. It is now read-only.
Ref #3838: Fix overall menu height on smaller devices #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanModal uses `topOffset` to determine the height of the presenting controller rather than the `longFormHeight`, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.
iccub
reviewed
Jun 25, 2021
| @@ -41,7 +41,7 @@ | |||
| "package": "PanModal", | |||
| "repositoryURL": "https://github.com/brave/PanModal", | |||
| "state": { | |||
| "branch": "master", | |||
| "branch": null, | |||
There was a problem hiding this comment.
Yeah I kept seeing it pop up so I let it through. Its Xcode fixing up its own mistake, it should have null'd out the branch when I changed it to a commit, but it didnt for some reason
iccub
approved these changes
Jun 25, 2021
soner-yuksel
approved these changes
Jun 25, 2021
iccub
pushed a commit
that referenced
this pull request
Jun 25, 2021
PanModal uses `topOffset` to determine the height of the presenting controller rather than the `longFormHeight`, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PanModal uses
topOffsetto determine the height of the presenting controller rather than thelongFormHeight, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.Summary of Changes
This pull request fixes a small bug caused by the #3845
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement