This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #4075: Sanitize Device Name while displaying in Sync Settings Screen #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Aug 19, 2021
|
|
||
| /// Encode Strings which are not sanitized for displaying | ||
| /// - Returns: Encoded String | ||
| public func encodeContaminatedString() -> String { |
There was a problem hiding this comment.
looks like a simple function, but maybe add a small unit test for it?
this can also be a computer property instead of a func
There was a problem hiding this comment.
can we use this code or remove it, looks like we are duplicating code here: https://github.com/brave/brave-ios/blob/development/Shared/Extensions/WKWebViewExtensions.swift#L83?
There was a problem hiding this comment.
Yeap I am carrying that exact function inside StringExtensions and adding test for it.
There was a problem hiding this comment.
Duplicate method is removed and added as computed property and unit tests are added
Changes at 26c16ac
iccub
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes low priority security issue for History Sync PR.
#3703 (comment)
Summary of Changes
This pull request fixes #4075
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)bug/enhancement