This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #5373: de amp debounce #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
5 times, most recently
from
435ad9c
to
34d9139
Compare
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
4 times, most recently
from
bad7c5f
to
1e5423f
Compare
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
from
1e5423f
to
47ef512
Compare
fmarier
suggested changes
Jun 24, 2022
Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift
Show resolved
Hide resolved
Tests/ClientTests/Web Filters/DebouncingResourceDownloaderTests.swift
Outdated
Show resolved
Hide resolved
Tests/ClientTests/Web Filters/DebouncingResourceDownloaderTests.swift
Outdated
Show resolved
Hide resolved
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
5 times, most recently
from
1e0ff20
to
7daa62c
Compare
fmarier
reviewed
Jul 8, 2022
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
2 times, most recently
from
5ff70f7
to
af8ed6b
Compare
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
2 times, most recently
from
9b1ad98
to
b95f614
Compare
fmarier
reviewed
Jul 11, 2022
Tests/ClientTests/Web Filters/DebouncingResourceDownloaderTests.swift
Outdated
Show resolved
Hide resolved
fmarier
reviewed
Jul 11, 2022
Tests/ClientTests/Web Filters/DebouncingResourceDownloaderTests.swift
Outdated
Show resolved
Hide resolved
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
2 times, most recently
from
3051317
to
e6c7263
Compare
fmarier
approved these changes
Jul 11, 2022
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
from
e6c7263
to
54bd010
Compare
iccub
force-pushed
the
js/5373-de-amp-debounce
branch
from
54bd010
to
9afe55e
Compare
Brandon-T
approved these changes
Jul 20, 2022
cuba
force-pushed
the
js/5373-de-amp-debounce
branch
2 times, most recently
from
fdc7972
to
0989ed4
Compare
iccub
force-pushed
the
js/5373-de-amp-debounce
branch
from
0989ed4
to
2028401
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #5373
Submitter Checklist:
NSLocalizableString()Test Plan:
Test plan can be found in the original android ticket:
brave/brave-browser#23121
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancementLinks
Sec review: https://github.com/brave/security/issues/925