Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5785: Add button that redirect users to Aurora for tokens that support Aurora bridging #5873

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Aug 16, 2022

Summary of Changes

For tokens that is
either a native token
or its contract address is one of https://aurora.dev/tokens
AND token has to be on ETH mainnet.

This pull request fixes #5785

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Uploading Simulator Screen Recording - iPhone 8 - 2022-08-25 at 14.21.11.mp4…

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.43 milestone Aug 16, 2022
@nuo-xu nuo-xu requested review from kylehickinson, StephenHeaps and a team August 16, 2022 20:36
@nuo-xu nuo-xu self-assigned this Aug 16, 2022
BraveWallet/WalletPromptView.swift Outdated Show resolved Hide resolved
BraveWallet/WalletPromptView.swift Outdated Show resolved Hide resolved
BraveWallet/Extensions/BraveWalletExtensions.swift Outdated Show resolved Hide resolved
@nuo-xu nuo-xu force-pushed the wallet-aurora-network branch from ac2bfd1 to 5bd7a39 Compare August 17, 2022 19:10
@nuo-xu nuo-xu requested a review from StephenHeaps August 17, 2022 19:11
@nuo-xu nuo-xu force-pushed the wallet-aurora-network branch from 5bd7a39 to 2902d74 Compare August 25, 2022 18:07
@nuo-xu nuo-xu requested a review from iccub August 25, 2022 19:25
@nuo-xu nuo-xu merged commit ce59f8f into development Aug 25, 2022
@nuo-xu nuo-xu deleted the wallet-aurora-network branch August 25, 2022 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bridge to Aurora button on asset detail screen
3 participants